@Dschoordsch I've found a really confusing issue. The symptom is that with my changes in this PR, resolving of an User type in OrganizationUser field would fail, even though all the data are there.

For example, this resolves fine and returns a proper userId:

{
  viewer {
    id
    organization(orgId: "xxxx") {
      organizationUsers {
        edges {
          node {
            userId
          }
        }
      }
    }
  }
}

However, if you try to resolve a User object:

{
  viewer {
    id
    organization(orgId: "xxxx") {
      organizationUsers {
        edges {
          node {
            user {
              preferredName
            }
          }
        }
      }
    }
  }
}

Returns:

{
  "errors": [
    {
      "message": "Cannot return null for non-nullable field OrganizationUser.user.",
      "locations": [
        {
          "line": 8,
          "column": 13
        }
      ],
      "path": [
        "viewer",
        "organization",
        "organizationUsers",
        "edges",
        0,
        "node",
        "user"
      ]
    }
  ],
  "data": {
    "viewer": {
      "id": "google-oauth2|xxxx",
      "organization": null
    }
  }
}

More interestingly, I've nailed down the issue to the removal of removeOrgUser: if I added the mutation back to packages/server/graphql/rootMutation.ts (together with the type definitions: packages/server/graphql/mutations/removeOrgUser.ts, packages/server/graphql/public/typeDefs/RemoveOrgUserPayload.graphql and packages/server/graphql/types/RemoveOrgUserPayload.ts then this issue does not exist anymore???

I suspect there's something to do with how the GraphQL schema is generated/updated. I remember you had some work around this area. Do you have some insights here? Thank you soooo much!

@tianrunhe Without looking into it in detail, I suspect we're not registering a necessary type anymore. What happens is that the old graphql resolvers (the ones not in the private/public subdirectories) are not imported automatically. So we probably indirectly imported a necessary resolver (I guess the one for User) through rootMutation and removeOrgUser. We now need to manually add it to rootTypes.

@Dschoordsch Thanks for that! I manually added OrganizationUser type in rootTypes.ts and it worked! Now this is ready for review, thx again!